Add support for custom GitHub API urls (for GHES support) #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradlarsen
approved these changes
May 30, 2023
There was a problem hiding this comment.
This looks good; thanks for the contribution @AdnaneKhan !
I made a few refinements:
- Added test cases for the URL joining code
- Made the URL joining code more robust after testing
- Expanded the command-line help documentation for the new
--api-urlarguments - Switched the
--api-urlargument type fromStringtoUrl
bradlarsen
added
the
content discovery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for a custom GitHub API url argument for both the scan and github commands. This allows NP to support GitHub Enterprise Server (by passing
https://GHESURL/api/v3/as the custom API url).